• TootSweet@lemmy.world
    link
    fedilink
    English
    arrow-up
    143
    arrow-down
    4
    ·
    edit-2
    5 months ago

    Back when I was the “new guy” code monkey at a fairly sizeable brick-and-mortor-and-e-retailer, I let the intrusive thoughts win and did some impromptu QA on the e-commerce site. (In the test environment. Don’t worry.)

    It handled things like trying to put “0” or “-1” or “9999999999999” or “argyle” quantity of an item in the cart just fine.

    But I know my 2’s-compliment signed integers. So I tried putting “0xFFFFFFFF” quantity of an item in my cart. Lo and behold, there was now -1 quantity of that item in my cart and my subtotal was also negative. I could also do things like put a $100.00 thing in the cart and then -1 quantity of something that cost $99.00 in the cart and have a $1.00 subtotal.

    (IIRC, there was some issue with McDonalds ordering kiosks at one time where you could compose an order with negative quantities of things to get an arbitrarily large unauthorized discount.)

    The rest of my team thought I was a fucking genius from that moment on. I highly recommend if you’re ever the “new guy” dev on a team and want to appear indispensible, find a bug that it would never occur to a QA engineer who doesn’t have a computer science degree to even test for.

    • The_v@lemmy.world
      link
      fedilink
      arrow-up
      52
      arrow-down
      1
      ·
      5 months ago

      A long time ago I was the guinea pig/first user for a company developed system.

      I often had my 1 year old at the time son with me when I worked on the weekend. He had a great time smashing buttons on the keyboard and randomly clicking the mouse on the test version. He found most of the bugs.

      • nilloc@discuss.tchncs.de
        link
        fedilink
        English
        arrow-up
        31
        ·
        5 months ago

        You must have been lying close attention to see how they were triggered though.

        Bug reports can be tough if you can’t repeat them. I’m glad you got some bonding time with littlie though, especially if you were on the clock.

        • BatrickPateman@lemmy.world
          link
          fedilink
          arrow-up
          18
          ·
          5 months ago

          Screen recording rules.

          The amount of times colleagues would dismiss bug reports because “they couldn’t reproduce” my steps rapidly declined when they didn’t only get the steps based on the video, but also the video.

          Take that Daniel, you lazy <beeep>

          Taught our test infrastructure to record and attach those recordings to the reports, too, before the manufacture of the testing tool implemented that. Good times.

    • zqwzzle@lemmy.ca
      link
      fedilink
      English
      arrow-up
      18
      ·
      5 months ago

      Everyone has a test environment. If you’re lucky you have a production environment too.

      • TootSweet@lemmy.world
        link
        fedilink
        English
        arrow-up
        16
        arrow-down
        1
        ·
        edit-2
        5 months ago

        To be fair, the team at the time was all business majors. (Is “Computer Information Systems” what they call that degree most places or just at my alma mater?) I think I was the only computer science major there.

        They’d done a surprisingly admirable job of cobbling together a working e-commerce, loss prevention, customer sercvice portal, orderfulfillment, and CMS suite. And their schooling was in, like, finance, MS Office, and maybe one semester on actual programming.

        None of them had ever learned how to count in binary. Let alone been exposed to 2’s compliment. And there were no QA engineers.

        Oh, there was the sysadmin. He had a temper and was a cowboy. If you asked him to do something, it’d be fuckin’ done, man. But you did not want to know how he made sausage. The boss asked him to set up a way for us to do code reviews and he installed Atlassian Fisheye/Crucible on a laptop under his desk. We used that for years. And a lot of the business logic of the customer-facing e-commerce site lived in the rewrite rules in the Apache config that only he had access to and no one else could decipher if they did have access.

        Those were good times. Good times.

        • jaybone@lemmy.world
          link
          fedilink
          arrow-up
          4
          ·
          5 months ago

          My school also had a major called “Computer Information Systems”. That was in the 90s. Do they still even offer that? Last I checked I didn’t see my school still offering that.

        • pseudo@jlai.lu
          link
          fedilink
          arrow-up
          3
          ·
          edit-2
          5 months ago

          I know a french degree that I would translate to Computer Information System in English but there is waay more computer science in it that what you described… I’m so glad I didn’t live thought the hardship of international studies!

    • redfellow@sopuli.xyz
      link
      fedilink
      arrow-up
      11
      ·
      5 months ago

      The McDonalds thing was simple. 90 cent burger, minus cheese, was -10 cents. Or something along that way. Basically the “hold the cheese” value was fixed but they forgot some items with cheese are piss cheap.

  • cheddar@programming.dev
    link
    fedilink
    arrow-up
    131
    arrow-down
    1
    ·
    edit-2
    5 months ago

    A QA engineer walks into a bar and asks where the bathroom is. The bar bursts into flames. The product owner says that the bar can be shipped anyway.

    • psud@aussie.zone
      link
      fedilink
      arrow-up
      30
      arrow-down
      4
      ·
      5 months ago

      As a PO I’m usually asking QA for some tests that actually show the product meets the requirements

      There might be 50 pages proving it rejects bad input, and nothing showing it can successfully handle a perfectly correct case. We seem bad at training testers.

      • cheddar@programming.dev
        link
        fedilink
        arrow-up
        12
        ·
        edit-2
        5 months ago

        That sounds strange. I cannot comment on your particular case without seeing the test artifacts.

        Generally speaking, there is nothing wrong with tests that ensure bad input doesn’t break the system, as this can easily lead to incorrect system states, damage to the environment, loss of data, money, reputation, and even lives - although most systems are not critical enough to threaten lives.

        You wouldn’t need QAs if you only needed to validate that the product meets the requirements. In a typical company, many people are involved in that process. This includes the developer who wrote the code, the developer who reviewed it, and the people who conduct acceptance testing, among others. If your developers produce code that doesn’t meet the requirements, you’re in trouble.

        I’m not saying that QA shouldn’t validate whether the system meets the requirements, but you don’t want them to do just that.

        • psud@aussie.zone
          link
          fedilink
          arrow-up
          3
          ·
          5 months ago

          If they didn’t properly test validation I would complain about that, what that regularly miss is a test showing correct function for each major use case

          • prettybunnys@sh.itjust.works
            link
            fedilink
            arrow-up
            2
            ·
            5 months ago

            So it sounds like you need to use the words to tell them, do you know testing types and strategies so you can tell them which to employ?

      • fibojoly@sh.itjust.works
        link
        fedilink
        arrow-up
        9
        ·
        5 months ago

        Doesn’t sound too weird to me. In my experience, devs always focus too much on positive / correct inputs, as they want things to work. Which is why you need testers that will catch all the weird crazy ways people can break things. Testers shouldn’t even see the code of it can’t handle nominal cases.

      • toynbee@lemmy.world
        link
        fedilink
        arrow-up
        5
        ·
        5 months ago

        The problem is that testers are competent, often intelligent individuals. Users, not so much.

  • eestileib@sh.itjust.works
    link
    fedilink
    arrow-up
    87
    ·
    5 months ago

    I still fondly remember the QA guy on the first consumer electronics project I worked on. He didn’t do scripting or test harnesses or dependency injection, he used the product and filed good bugs telling us what would fuck up our customer’s expectations.

    A good QA person helps with product design too if you let them.

    Andy B, I’d work with you again in a second.

    • dactylotheca@suppo.fiOP
      link
      fedilink
      English
      arrow-up
      28
      ·
      edit-2
      5 months ago

      Some plans less so than others.

      Also, I like this framing of users as the enemy. Matches my experience, really.

  • Captain Aggravated@sh.itjust.works
    link
    fedilink
    English
    arrow-up
    6
    ·
    edit-2
    5 months ago

    Ninety-nine billion, nine hundred ninety-nine million, nine hundred ninety-nine thousand nine hundred ninety-nine bottles of beer on the wall,

    Ninety-nine billion, nine hundred ninety-nine million, nine hundred ninety-nine thousand nine hundred ninety-nine bottles of beer,

    You take one down, pass it around,

    Ninety-nine billion, nine hundred ninety-nine million, nine hundred ninety-nine thousand nine hundred ninety-eight bottles of beer on the wall.

    • TheOakTree@lemm.ee
      link
      fedilink
      arrow-up
      3
      ·
      5 months ago

      Unfortunately the bar was built on long int so it overflowed 23 times and landed on about 1.2 billion.

      One billion, two-hundred fifteen million, seven-hundred fifty-two thousand, two-hundred-something bottles of beer on the wall, one billion, two-hundred fifteen million, seven-hundred fifty-two thousand, two-hundred-something bottles of beer! Take one down, pass it around…

      One less bottle of beer on the wall :)

      • Captain Aggravated@sh.itjust.works
        link
        fedilink
        English
        arrow-up
        1
        ·
        edit-2
        5 months ago

        I wonder what would happen if it was a singed long, and it landed somewhere in the negatives after overflowing multiple times?

        Negative forty-eight thousand, six hundred thirty-three bottles of beer on the wall,

        Negative forty-eight thousand, six hundred thirty-three bottles of beer

        You take one down, pass it around,

        Negative forty-eight thousand, six hundred thirty-four bottles of beer on the wall

        • TheOakTree@lemm.ee
          link
          fedilink
          arrow-up
          1
          ·
          5 months ago

          Well, silly me, I should have specified that I did my calculation with signed long, though it shouldn’t affect the outcome much given my rounding at the hundreds.

          I like the idea of beer debt to the wall, though!