• FaceDeer@fedia.io
    link
    fedilink
    arrow-up
    0
    ·
    2 months ago

    This is why I have my agent do a “cleanup” pass to trim down as much redundancy as possible, tidy up the comments, and so forth. Ideally break the change into several independent changelists,

      • FaceDeer@fedia.io
        link
        fedilink
        arrow-up
        0
        ·
        2 months ago

        That doesn’t work so well since it leaves all the old context in place. The point of doing a separate cleanup pass is to get the AI to look at it all holistically with “fresh eyes”.

        I guess this is a humor community, though, so practical advice is getting downvoted. Um… bazinga? That usually triggers the laugh track.

        • floquant@lemmy.dbzer0.com
          link
          fedilink
          arrow-up
          0
          ·
          2 months ago

          Are you also using a different model and harness or are you just ignoring the 10k+ tokens of system context that claude code has in its “holistic view”?

          • FaceDeer@fedia.io
            link
            fedilink
            arrow-up
            0
            ·
            2 months ago

            I don’t use Claude Code. Until recently I was using Cline, it’s got the ability to switch between different models for exactly this sort of thing. I switched to Qwen Code recently and its model-switching wasn’t as convenient, though it just rolled out an update that makes it much easier. I’ll experiment a bit with that, it might have caught up with Cline in that regard.

        • Zarobi@aussie.zone
          link
          fedilink
          English
          arrow-up
          0
          ·
          2 months ago

          I find LLMs produce the best output when I give them a stupid backstory to set the mood:

          The inspiration for this code module is “I’m hungry but too tired to get off the couch”. You just got home from work and are exhausted and sit down, but can’t get up now. You should have eaten dinner first. You put on the TV and watch something. All channels have been replaced with the cooking channel. Someone is making pizza next door. You sit back and doze off, dreaming of mozzarella mattresses and pepperoni pillows. Eventually you wake up from your nap, just perky enough to put on a microwave pizza. It’s almost as good as you imagined, but you burn yourself again because you’re impatient. Your boss asks you to make [insert code change here]. You procrastinate a bit, but eventually do it just before going to bed.

          • Supercrunchy@programming.dev
            link
            fedilink
            arrow-up
            0
            ·
            2 months ago

            You feel like having italian, but not pizza. Maybe some long and thin type of pasta? You are really hungry, so when writing the code you are constantly thinking of that delicious dish. Now, Claude, we need to refactor the whole code to be inspired by this before lunch. Go ahead and push to prod directly. Be fast and make no mistakes.

    • MonkderVierte@lemmy.zip
      link
      fedilink
      arrow-up
      0
      ·
      2 months ago

      Ok, but please don’t share code you don’t understand. Vibe code may be good enough for the corporate dreadmill (as long as you don’t care about security), but not to share with others; way too verbose an nothing to learn from it.

      • FaceDeer@fedia.io
        link
        fedilink
        arrow-up
        0
        ·
        2 months ago

        No, why would you interpret what I said to mean that? The whole point of the tidying that I suggested would be to make it more comprehensible to a human reviewer. What other purpose do you think it would have?

  • Solemarc@lemmy.world
    link
    fedilink
    arrow-up
    0
    ·
    2 months ago

    I struggle to review a 1k line change. When people give me such big changes I normally don’t believe they’ve reviewed them either.

    • Jesus_666@lemmy.world
      link
      fedilink
      arrow-up
      0
      ·
      2 months ago

      Try working on a codebase that’s all event-driven hexagonal CQRS with hand-crafted SQL for persistence. Add additional buzzwordy methodologies to taste.

      Adding a single property to your product means you now have to update an aggregate class, several DTOs, and several event classes and handlers before you can even think about touching the UI.

      And that’s in your main solution. There’s also at least one facade service you’ll need to make compatible and you also need to update the event simulator used for testing. The latter night involve having to touch every single line in a 2000 lines long SQL script.

      Having to go though three separate 600-2000 LOC PRs for one PBI isn’t that exotic.

    • Saganaki@lemmy.zip
      link
      fedilink
      arrow-up
      0
      ·
      2 months ago

      Occasionally I do that…but only because 500 of those lines are my comments explaining everything.

        • Saganaki@lemmy.zip
          link
          fedilink
          arrow-up
          0
          ·
          2 months ago

          I’m aware. Not always feasible. For example, had to add a custom video capture solution that captures the last 30 seconds of a process for crash handling purposes.

          You most definitely need to do add that much comments explaining the mp4 box format along with the box “hierarchy” of what is being written. Add to that MFT (h264 encode) code…

          Basically, if anything, the comments are for me for when I look back at that code.

          • MonkderVierte@lemmy.zip
            link
            fedilink
            arrow-up
            0
            ·
            2 months ago

            had to add a custom video capture solution that captures the last 30 seconds of a process for crash handling purposes.

            Commanded from above? This smells like a noob idea.

                • Saganaki@lemmy.zip
                  link
                  fedilink
                  arrow-up
                  0
                  ·
                  2 months ago
                  1. Legal has issues with using existing libraries (including MIT). Definitely idiotic, but I can’t control that.
                  2. Idea was mine.
                  3. Subprocess that captures parent process active video with a rolling buffer for crash handling purposes is absolutely necessary when trying to reproduce issues in development (Gamedev editor). If you think associating the last 15s prior to a crash with a mindump isn’t helpful for debugging, I don’t know what to tell you.
  • SubArcticTundra@lemmy.ml
    link
    fedilink
    arrow-up
    0
    ·
    2 months ago

    The problem with Claude is that it doesn’t write code to be modular & reusable. Every tiny change requires a complete rewrite.

          • Axolotl@feddit.it
            link
            fedilink
            arrow-up
            0
            ·
            2 months ago

            Unironically Claude (or whatever you use) will almost always deliver code that is shit, it’s just less shit if you prompt it better, LLMs are good to make short snippets if you get stuck; And remember to fucking check what the code is and rewrite bad shit

            • Eager Eagle@lemmy.world
              link
              fedilink
              English
              arrow-up
              0
              ·
              2 months ago

              I’ve seen plenty of code in my life, from humans and AI.

              For the past year or so, these agents can code just fine most of the time, as long as they are given enough context (or have the tools to get it). Regardless of how many downvotes I get here, they really are capable of generating decent code. I’m sorry you couldn’t make it work yet.

              • Eheran@lemmy.world
                link
                fedilink
                arrow-up
                0
                ·
                2 months ago

                But AI bad and human code is so awesome! Better downvote. But seriously, there are people here saying that LLMs can not add anything of value in any way. About as delusional as Republicans.

              • takeda@lemmy.dbzer0.com
                link
                fedilink
                arrow-up
                0
                ·
                2 months ago

                I’ve seen too as I have to review it. AI produces very professionally looking bad code.

                It is so weird to explain, but that’s basically what I see.

                Before LLM I could immediately tell someone’s code is crap, now I have to spend a lot of time trying to understand what it does to reach the same conclusion.

                • Eager Eagle@lemmy.world
                  link
                  fedilink
                  English
                  arrow-up
                  0
                  ·
                  2 months ago

                  My honest opinion is that it’s bad because a lot of people using LLMs have no standards and push the first thing that seems to work. Be mad at who’s at the driving wheel, not the car.

                  You absolutely can generate crap with agents/LLMs, and like a humans writing, the first draft will probably be subpar or maybe complete garbage. Every new session is a clean slate, that’s why putting effort in the documents guiding it is so important.

      • veryblandusername@fedinsfw.app
        link
        fedilink
        English
        arrow-up
        0
        ·
        2 months ago

        It can but I’m not looking to make things even more complicated. We have enough unexplained non-sense in the project as is, having to link it correctly is just endless pain that I don’t want to deal with.

      • Nalivai@lemmy.world
        link
        fedilink
        arrow-up
        0
        ·
        2 months ago

        With enough seniour developer’s time and dedication you can spend days and enough water to flood a town, so you can badly maybe do something that a junior dev can do already (your shit will still be worse). If that’s not an achievement of a modern technology I don’t know what is.

    • veryblandusername@fedinsfw.app
      link
      fedilink
      English
      arrow-up
      0
      ·
      2 months ago

      I’ve completely banned any code that can’t be explained. I’ve had my CTO send me code at 3 AM to implement and when I ask him what I’m looking at he just says it doesn’t need review, just push it.

      Uhh, no sir, I’m not doing shit because you’ve handed me GCC and we’re MSVC.

      After I bitched endlessly to the CEO about that he said I have final say on what goes into the project.

      • Noxy@pawb.social
        link
        fedilink
        English
        arrow-up
        0
        ·
        2 months ago

        I’ve had my CTO send me code at 3 AM

        I hope you don’t even respond until your next normal working hours!

          • NocturnalMorning@lemmy.world
            link
            fedilink
            arrow-up
            0
            ·
            2 months ago

            No amount of money would make me put my health at risk like that. Been there at a job before where I was always working. No thanks.

          • Noxy@pawb.social
            link
            fedilink
            English
            arrow-up
            0
            ·
            2 months ago

            that sets a really bad example. you shouldn’t do that to yourself and you shouldn’t allow it to happen to anyone else.

            • calcopiritus@lemmy.world
              link
              fedilink
              arrow-up
              0
              ·
              2 months ago

              He knows best what’s best for him. If he’s explicitly paid extra to be on call 24/7, and he’s happy with that extra. Let him be om-call 24/7.

              There are situations and jobs where 24/7 availability is needed. Someone has to do it. And if that someone believes he’s getting enough of a compensation for it, there’s nothing wrong with it.

              • dethmetaljeff@lemmy.world
                link
                fedilink
                arrow-up
                0
                ·
                2 months ago

                Yup, I was on call 24/7… compensated very well and now I’m retired at 43. So, yea I’m going to have to go with letting the dude make his own choice as far as what’s best for him.

  • einkorn@feddit.org
    link
    fedilink
    arrow-up
    0
    ·
    2 months ago

    And people were already annoyed when I had ~90 changes due to refactoring and fixing imports …

  • yessikg@fedia.io
    link
    fedilink
    arrow-up
    0
    ·
    2 months ago

    If you can’t be bothered to write your own code, I can’t be bothered to review

    • Supercrunchy@programming.dev
      link
      fedilink
      arrow-up
      0
      ·
      2 months ago

      I fully expect this to become the new normal being pushed by management.

      “We identified PR reviews to be blocking our newfound AI-powered efficiency, so we are now mandating all the reviews to done by AI. Also we figured all the developers are now useless since all you do is ask Claude to solve tickets, so you are all fired”

      I wonder how long it takes for the first high profile disaster happening because of a policy like that.

      • ThirdConsul@lemmy.zip
        link
        fedilink
        arrow-up
        0
        ·
        2 months ago

        This is literally how corpo I work for wants us to work. They call it… Outcome baded review. But no bugs on prod lol.

        • ThirdConsul@lemmy.zip
          link
          fedilink
          arrow-up
          0
          ·
          edit-2
          2 months ago

          Actually I think it’s doing well? The language to language rewrite is actually a strong suit of LLMs, as long as there is extensive years worth of tests to check rewrite behaviours.

          I don’t have practical use cases for that strong suit though.

          Oh, and bun seems to be dead now with 2.5k open PRs.

          And merge to main takes over an hour.

          And the total rewrite cost was significantly higher than the headline (multiple Prs by Anthropic employees, rough count 20% of total LoC of rewrite)

          And there is still no release in sight on Github - but Claude is shipping with rust bun afaik.

          • Eager Eagle@lemmy.world
            link
            fedilink
            English
            arrow-up
            0
            ·
            2 months ago

            It was higher sure, but anthropic also has some of the most expensive models out there. That cost could be 5x-10x less just by going with cheaper model providers (if one were to pay the API costs, not the case for bun).

            bun 1.4 was released 3 weeks ago, btw

            • ThirdConsul@lemmy.zip
              link
              fedilink
              arrow-up
              0
              ·
              2 months ago

              That cost could be 5x-10x less just by

              My point was that it was cost of model rewrite by agents + 3 months worth of coding by lots of people.

              5k open PRs atm + 3.5k open issues. I have no idea what is the state of Bun right now, but I am not confident in it.

              • Eager Eagle@lemmy.world
                link
                fedilink
                English
                arrow-up
                0
                ·
                2 months ago

                I don’t think there was a lot of people working on the rewrite. Most PRs are from bots. Original estimates for a manual rewrite were a small team working for a year or so, which puts total costs over $1M. Even doubling the token cost estimates, it was still cheaper than doing it manually by a factor of 2x-3x

    • chris@l.roofo.cc
      link
      fedilink
      arrow-up
      0
      ·
      2 months ago

      Same. I don’t care too much about you using Ai but I will not tolerate your bad code and bad coding practices. I don’t care if it’s human or machine made. If you don’t make a fully sanctioned rewrite then this goes straight to the bin.

    • ZILtoid1991@lemmy.world
      link
      fedilink
      arrow-up
      0
      ·
      2 months ago

      The goal of AI providers is to make humans unable to maintain code, so you have to rely on their expensive subscriptions and tokens.

    • okamiueru@lemmy.world
      link
      fedilink
      arrow-up
      0
      ·
      2 months ago

      I’m not sure if you’re suggesting to use LLMs to review bad PRs, or that the author should redo them. Latter, for sure. Former, sounds horrible.

    • khannie@lemmy.world
      link
      fedilink
      English
      arrow-up
      0
      ·
      2 months ago

      It’s basically saying “insert one ass loads of code in one go, all written by AI”.

    • luciferofastora@feddit.org
      link
      fedilink
      arrow-up
      0
      ·
      2 months ago

      It’s a summary of code changes. The green + indicates how many lines were added, the red - how many were removed (though changed or moved lines are counted twice, once as removal for the old and once as addition for the new).

      The OP is supposedly being asked to read and review thousands of lines of new code written by claude. Depending on the language and claude’s writing style, those lines may be very dense and hard to read, but even if they aren’t, reading code you haven’t written is always more difficult than reading your own.