• 6 Posts
  • 124 Comments
Joined 3 years ago
cake
Cake day: June 20th, 2023

help-circle

  • In my experience code review is often about the logic rather than the code itself. For example do you really need to copy the whole user object just to read their username? Can’t you just pass the username in as a string instead? Static validation and test suites should already of eliminated any code errors. If you show up to a code review and the code doesn’t compile, you’re going to have a bad time. Stuff like calculating the same distance between two objects multiple times should be called out in code review, maybe extract that into a function. Reaching out to a database to get the same value repeatedly should be called out, maybe store it as a local variable.

    One time I was reviewing some code which interfaces with an external third party piece of hardware which the api required the serial number for licensing. The programmer hard coded the serial number into the code. If we swapped it due to hardware malfunction we would need to update the software. If we got a second one we would need to maintain two code bases. This should be in a configuration file or something. Ai will not catch that. Static testing won’t catch this. Test suites running on the piece of hardware we had, wouldn’t catch this. Only a human reviewer would.





  • It’s fanuc cnc… Incredibly useful and precise but OLD! They literally still support programs from bubble tape if you need. It was basically hardware constrained initially but fixing it would break backwards compatibility which is a super selling point for them to government and long term industries.

    Their controllers are mad expensive (budget version is like 30k last I checked), their support is top notch(tech typically on site within 24 hours with every possible board which may be bad so they can get you running and charge you later), they are incredibly precise and can do things other systems legally can not(a trainer I knew said “if you can move in 5 dimensions at once you can do some interesting things with nuclear energy so those require special clearance to sell”). Basically if you need them you NEED them, if you don’t then you don’t.









  • I never understand these types of actions(the destruction I mean). Like ok, you’re a criminal… You steal from a store, you get a benefit (what ever you stole)… You kill someone, you were worried for the rest of your life(either they were going to kill or harm you or you were going to be caught and go to jail)… You rape someone, you couldn’t control your emotions or desires… You drink and drive or do drugs, ok you get some sense of pleasure from the chemicals… Maybe you destroy property because you feel like it violated your rights(flock cameras). Not condoning these acts but I can kind of see the logic.

    This was like thinking “these kids don’t deserve happiness” … The fuck is wrong with you?